chore(ctb): Remove TS Utils #6151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for opstack-docs canceled.
|
roninjin10
reviewed
Jun 26, 2023
| @@ -3,3 +3,4 @@ export * from './utils' | |||
| export * from './cross-chain-messenger' | |||
| export * from './adapters' | |||
| export * from './l2-provider' | |||
| export * from './contract-defs' | |||
There was a problem hiding this comment.
Let's not export it for now and isntead plan on removing it completely in a future pr. This abstraction is a bad abstraction for a bunch of reasons
- Hardcoded to only work on CJS doesn't work on any project using the more modern and recommended ESM
- Not typesafe
- Not code splittable, biggest tech debt the sdk has for frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
contract-defs.tsutilities and moves them into the sdk.