deps: update foundry #9038
Merged
deps: update foundry #9038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates foundry to the commit `9e2830d7f0566e0d00b1104eeaedd5032a4e556e`. Includes the `vm.dumpState` cheatcode implemented in foundry-rs/foundry#6827. This will unblock the migration of the genesis generation to solidity to improve the devex of the L2 contracts and allow us to delete a lot of custom Go code as well as reduce flakes in CI due to not being able to find the `genesis.json`.
|
Just double checking local install works, one sec |
|
Perfect |
refcell
approved these changes
Jan 17, 2024
tynes
added a commit
that referenced
this pull request
Jan 17, 2024
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to #9042 which fixes the broken build from #8920. I don't think that #8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in #9038 so we need a successful build of `ci-builder`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to #9042 which fixes the broken build from #8920. I don't think that #8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in #9038 so we need a successful build of `ci-builder`.
dshiell
pushed a commit
to polymerdao/optimism-dev
that referenced
this pull request
Jan 22, 2024
Updates foundry to the commit `9e2830d7f0566e0d00b1104eeaedd5032a4e556e`. Includes the `vm.dumpState` cheatcode implemented in foundry-rs/foundry#6827. This will unblock the migration of the genesis generation to solidity to improve the devex of the L2 contracts and allow us to delete a lot of custom Go code as well as reduce flakes in CI due to not being able to find the `genesis.json`.
dshiell
pushed a commit
to polymerdao/optimism-dev
that referenced
this pull request
Jan 22, 2024
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to ethereum-optimism#9042 which fixes the broken build from ethereum-optimism#8920. I don't think that ethereum-optimism#8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in ethereum-optimism#9038 so we need a successful build of `ci-builder`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates foundry to the commit
9e2830d7f0566e0d00b1104eeaedd5032a4e556e.Includes the
vm.dumpStatecheatcode implemented in foundry-rs/foundry#6827.This will unblock the migration of the genesis generation to solidity to
improve the devex of the L2 contracts and allow us to delete a lot of
custom Go code as well as reduce flakes in CI due to not being able to
find the
genesis.json.