ci-builder: fix build #9042
Merged
ci-builder: fix build #9042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was broken with #8920 due to the new `jq` dependency not being present in the builder image. Fix by installing `jq` in the builder image.
WalkthroughWalkthroughThe Dockerfile has been updated to change a package installation and to use a newer base image. The Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
clabby
approved these changes
Jan 17, 2024
refcell
approved these changes
Jan 17, 2024
trianglesphere
approved these changes
Jan 17, 2024
tynes
added a commit
that referenced
this pull request
Jan 17, 2024
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to #9042 which fixes the broken build from #8920. I don't think that #8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in #9038 so we need a successful build of `ci-builder`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to #9042 which fixes the broken build from #8920. I don't think that #8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in #9038 so we need a successful build of `ci-builder`.
dshiell
pushed a commit
to polymerdao/optimism-dev
that referenced
this pull request
Jan 22, 2024
Was broken with ethereum-optimism#8920 due to the new `jq` dependency not being present in the builder image. Fix by installing `jq` in the builder image.
dshiell
pushed a commit
to polymerdao/optimism-dev
that referenced
this pull request
Jan 22, 2024
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to ethereum-optimism#9042 which fixes the broken build from ethereum-optimism#8920. I don't think that ethereum-optimism#8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in ethereum-optimism#9038 so we need a successful build of `ci-builder`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was broken with #8920
due to the new
jqdependency not being present in the builder image.Fix by installing
jqin the builder image.