fix: Replay transactions that can be finalized

[roninjin10]

Fixes bug where finalize being called with a tx that needed to be replayed would fail.

[roninjin10]

• fix: Replay transactions that can be finalized #9969 👈
• fix: make sdk-next tests run in ci #10003
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite

[semgrep-app]

Semgrep found 1 iterate-over-empty-map finding:

• op-batcher/compressor/compressors.go
  • L19-31 - Triage

Iteration over a possibly empty map Kinds. This is likely a bug or redundant code

_{Ignore this finding from iterate-over-empty-map.}

[coderabbitai]

Walkthrough

The recent updates focus on enhancing the cross-chain messaging system in the SDK, encompassing job renaming, CircleCI configuration updates, SDK logic refinements, and testing framework adjustments. Notable improvements include better handling of failed messages and support for new blockchain networks, collectively boosting the SDK's reliability and flexibility in cross-chain operations.

Changes

Files	Summary
.circleci/config.yml	Renamed jobs, updated commands, adjusted job configuration.
packages/sdk/src/.../cross-chain-messenger.ts	Deprecated parameters, refactored logic, improved message replay mechanism.
packages/sdk/test-next/README.md	Transitioned to using anvil for tests, revised testing methodology.
packages/sdk/test-next/bridgeEcoToken.spec.ts packages/sdk/test-next/messageStatus.spec.ts packages/sdk/test-next/proveMessage.spec.ts	Skipped specific test suites for functionalities.
packages/sdk/test-next/failedMessages.spec.ts	Added functionality for replaying failed messages in the cross-chain system.
packages/sdk/test-next/testUtils/ethersProviders.ts packages/sdk/test-next/testUtils/viemClients.ts	Updated providers, introduced new clients for different chains.
.changeset/young-gorillas-roll.md	Introduced a patch addressing a bug related to replayable transactions.
bedrock-devnet/devnet/__init__.py	Adjusted max_workers parameter in devnet_test function for concurrency control.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 42.40%. Comparing base (7fd5a19) to head (cc59585).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #9969      +/-   ##
===========================================
- Coverage    42.52%   42.40%   -0.13%     
===========================================
  Files           73       73              
  Lines         4816     4830      +14     
  Branches       759      766       +7     
===========================================
  Hits          2048     2048              
- Misses        2662     2676      +14     
  Partials       106      106              

Flag	Coverage Δ
cannon-go-tests	82.29% <ø> (ø)
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	26.72% <ø> (ø)
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	44.03% <ø> (ø)
sdk-tests	40.27% <0.00%> (-0.34%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/sdk/src/cross-chain-messenger.ts	45.15% <0.00%> (-1.03%)	⬇️

[smartcontracts]

Great work, looks good (I think)