-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fjord: Add FastLZ L1-Cost function specs #25
Conversation
Are we going to want to adjust |
EDIT: we met about this and decided to derisk the upgrade by hardcoding the constants for now. We may want to introduce ability for this to be configured, either by L1 attributes or by putting the logic in an L2 contract, but for now hardcoding is fine. |
Generally looks good |
This looks great! Thank you. We would like to modularize the specs a bit so the diff that comes with a particular network upgrade is very obvious. If you could rebase and move the new specs into the |
cc67dc6
to
72eaf9d
Compare
5b732e9
to
4f67a43
Compare
499210e
to
d767284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! Also confirmed that the new GPO deployment code matches the monorepo PR.
Co-authored-by: Michael de Hoog <michael.dehoog@coinbase.com> Co-authored-by: Yukai Tu <yukai.tu@coinbase.com> Co-authored-by: Sebastian Stammler <stammler.s@gmail.com>
Description
Specs for the FastLZ L1 cost function changes, targeting Fjord. See https://hackmd.io/@mdehoog/compression-analysis for a detailed write up.
Related: