Shifted the png files of eip-823 from root to assets #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
|
Thanks! |
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Jul 19, 2018
* epi drafted * minor changes made * minor changes made * changes to sender interface and added diagrams * added diagrams in the markdown * updated the diagrams * update the headers * made changes suggested by @Arachnid * added png to assets folder
axic
reviewed
Jun 26, 2019
|
|
||
| NOTE: After the successful exchange the contract on right owns some tokens of the contract on the left. | ||
|
|
||
| #### Exchanging And Spending Tokens | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
@kashishkhullar you have added the files to the assets directory, but these links are pointing to a remote repo. Can you change these links to be .. /assets/eip-823/eip-823-token-exchange-standard-visual-representation-2.PNG ?
There was a problem hiding this comment.
I have updated the links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.