-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shifted the png files of eip-823 from root to assets #1069
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
Thanks! |
* epi drafted * minor changes made * minor changes made * changes to sender interface and added diagrams * added diagrams in the markdown * updated the diagrams * update the headers * made changes suggested by @Arachnid * added png to assets folder
|
||
NOTE: After the successful exchange the contract on right owns some tokens of the contract on the left. | ||
|
||
#### Exchanging And Spending Tokens | ||
|
||
![token-exchange-standard-visual-representation-2](https://raw.githubusercontent.com/kashishkhullar/EIPs/master/EIPS/token-exchange-standard-visual-representation-2.PNG) | ||
![token-exchange-standard-visual-representation-2](https://raw.githubusercontent.com/kashishkhullar/EIPs/master/assets/eip-823/eip-823-token-exchange-standard-visual-representation-2.PNG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kashishkhullar you have added the files to the assets
directory, but these links are pointing to a remote repo. Can you change these links to be .. /assets/eip-823/eip-823-token-exchange-standard-visual-representation-2.PNG
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.