-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shifted the png files of eip-823 from root to assets #1069
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1bfce4d
epi drafted
kashishkhullar 0c2f52d
minor changes made
kashishkhullar 3266ca3
minor changes made
kashishkhullar b5b67d9
changes to sender interface and added diagrams
kashishkhullar 839f81f
added diagrams in the markdown
kashishkhullar 8e37753
updated the diagrams
kashishkhullar b367bc5
update the headers
kashishkhullar 956f075
Merge branch 'master' of https://github.com/ethereum/EIPs
kashishkhullar 1021147
made changes suggested by @arachnid
kashishkhullar 998ec92
Merge branch 'master' of https://github.com/ethereum/EIPs
kashishkhullar f0f3169
added png to assets folder
kashishkhullar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kashishkhullar you have added the files to the
assetsdirectory, but these links are pointing to a remote repo. Can you change these links to be.. /assets/eip-823/eip-823-token-exchange-standard-visual-representation-2.PNG?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!