Update EIP-2982: Move to Final

[djrtwo]

Review period is over. Moving eip 2982 to Final

[eth-bot]

All tests passed; auto-merging...

(pass) eip-2982.md

classification
updateEIP

• passed!

(pass) assets/eip-2982/2982-issuance.png

classification
ambiguous

• file assets/eip-2982/2982-issuance.png is associated with EIP 2982; because there are also changes being made to EIPS/eip-2982.md all changes to corresponding assets are also allowed

(pass) assets/eip-2982/arxiv-1710.09437-Casper-the-Friendly-Finality-Gadget.pdf

classification
ambiguous

• file assets/eip-2982/arxiv-1710.09437-Casper-the-Friendly-Finality-Gadget.pdf is associated with EIP 2982; because there are also changes being made to EIPS/eip-2982.md all changes to corresponding assets are also allowed

(pass) assets/eip-2982/arxiv-1809.09044-Fraud-and-Data-Availability-Proofs--Maximising-Light-Client-Security-and-Scaling-Blockchains-with-Dishonest-Majorities.pdf

classification
ambiguous

• file assets/eip-2982/arxiv-1809.09044-Fraud-and-Data-Availability-Proofs--Maximising-Light-Client-Security-and-Scaling-Blockchains-with-Dishonest-Majorities.pdf is associated with EIP 2982; because there are also changes being made to EIPS/eip-2982.md all changes to corresponding assets are also allowed

(pass) assets/eip-2982/arxiv-2003.03052-Combining-GHOST-and-Casper.pdf

classification
ambiguous

• file assets/eip-2982/arxiv-2003.03052-Combining-GHOST-and-Casper.pdf is associated with EIP 2982; because there are also changes being made to EIPS/eip-2982.md all changes to corresponding assets are also allowed

(pass) assets/eip-2982/ef-Discouragement-Attacks.pdf

classification
ambiguous

• file assets/eip-2982/ef-Discouragement-Attacks.pdf is associated with EIP 2982; because there are also changes being made to EIPS/eip-2982.md all changes to corresponding assets are also allowed

(pass) assets/eip-2982/iacr-2015-702-Demystifying-Incentives-in-the-Consensus-Computer.pdf

classification
ambiguous

• file assets/eip-2982/iacr-2015-702-Demystifying-Incentives-in-the-Consensus-Computer.pdf is associated with EIP 2982; because there are also changes being made to EIPS/eip-2982.md all changes to corresponding assets are also allowed

[axic]

I know this is a touchy EIP and having external links is frowned upon by some. I'll make a few suggestions:

1. Replace external image links with images stored in the EIP repository (it should be ./assets/eip-2982/...).
2. Make sure that all external GitHub links point to a specific tag and not master, if possible.
3. Use the description: preamble instead of the Simple Summary (Move 2982 to Last Call #3676 (comment))
4. Consider removing/updating potentially outdated information.

On point 4, there's this text in the document currently:

A hard fork of the eth2 beacon chain is planned for 5 months after genesis. This hard fork will adjust INACTIVITY_PENALTY_QUOTIENT, PROPORTIONAL_SLASHING_MULTIPLIER, and MIN_SLASHING_PENALTY_QUOTIENT to their final, more secure values.

Did this fork pass yet? Is this relevant to the spec?

[djrtwo]

As for (2), we don't control all repos referenced. Does a commit work as a sufficient tag?

[djrtwo]

handled everything but the external links to a tag

[lightclient]

Looks good to me. @MicahZoltu @axic: are we okay to move this to final?

[MicahZoltu]

I still have many problems with this EIP (external links galore), and don't even think it should be an EIP (see prior discussions on the topic). That being said, despite appearances this isn't a dictatorship so if you and @axic want to merge I won't take any action to stop you.

[djrtwo]

checking in on this one

[lightclient]

I would like to merge this to final - only two notes on that:

• given the "great renaming" would it make sense to update the "eth2" terminology in this EIP?
• due to @MicahZoltu's opposition, I would like if @axic would weigh in

[djrtwo]

I'm fine either way on the naming

[SamWilsn]

With the recent updates to EIP-1, I think the external links need to be addressed before merging, which means restarting the Last Call process, if I understand correctly.

I am abstaining from approving/rejecting this EIP for now *hides*

[Pandapip1]

Closing since the author hasn't been seen in >3 months (the stale threshold).

[lightclient]

We need to move this EIP to final.

[github-actions]

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

[Pandapip1]

This is kind of an important EIP, so let's keep this not stale for now.

[Pandapip1]

Anyways - a new PR should probably be created. @djrtwo appears to have gone AWOL.

[djrtwo]

I stopped checking in here because it was at an impasse. I'm happy to do whatever to get it moved to Final but don't have a strong opinion on the path to get there

I can click merge on this and resubmit if that would in fact push it over the edge -- djrtwo#12

[Pandapip1]

I can click merge on this

All that's needed is for you to click merge on that, and it should update this PR. We can move forward from there.

[Pandapip1]

If this passes CI LGTM

Outdated