Improvement for FetchRequest ( v6 )

[ghost]

Update with latest version

For anyone interested to working with ethers.js with proxy connection, I have updated the example script to look more clear

https://github.com/kaliubuntu0206/ethers-proxy-example/blob/main/index.js

Describe the Feature

As per discussed from discord

Moving the global getUrlFunc inside the FetchRequest ( or use it as a fallback if null )

https://github.com/ethers-io/ethers.js/blob/main/src.ts/utils/fetch.ts#L80

const f = new FetchRequest(url);
f.registerGetUrl(customFunc);
f.send();

And adding factory for getUrlFunc

import { setupHttpProxy, setupHttpsProxy, setupSocksProxy } from "@ethers-ext/geturl-proxy-agent"
FetchRequest.registerGetUrl(FetchRequest.createGetUrl({ agent }));

Related: #4337

Code Example

No response

[ricmoo]

Also, adding a factory FetchRequest.createGetUrl(options), allowing easy custom agents via FetchRequest.registerGetUrl(FetchRequest.createGetUrl({ agent })).

Also provide examples in the cookbook of using this factory. :)

[ricmoo]

I've made an initial commit for the next minor bump which includes these changes.

Please take quick look and let me know if it seems sufficient. I'll also add some cookbook recipes to demonstrate how to use it.

Thanks! :)

[ghost]

@ricmoo I have made a quick test and verified that we could init new FetchRequest with our custom getUrlFunc without impacting global function.

( BTW, shouldn't the branch name be v6.8-progress since it is based on v6? )

[ricmoo]

Ugh yes. That’s a tragic typo… :p

I’ll rename it in a bit.

Awesome. And did setting an agent work globally too?

[ghost]

@ricmoo Yes, I have tested with the locally built ethers.js with the example script https://github.com/kaliubuntu0206/ethers-proxy-example/commit/934511a63acc53d90d10a70498818a8cbc8318e2 and the branch changes worked as well

[ricmoo]

This has been published in v6.8.0.

Thanks for the suggestion! :)

[ghost]

For anyone interested to working with ethers.js with proxy connection, I have updated the example script to look more clear

https://github.com/kaliubuntu0206/ethers-proxy-example/blob/main/index.js

[ricmoo]

Oh, with v6.8.0, I think you should be able to just do: FetchRequest.registerGetUrl(FetchRequest.createGetUrl({ agent: new HttpsProxyAgent(HTTP_PROXY) })) and everything should just work. :)

[ghost]

@ricmoo Yes I think I have missed the updates on src.ts/utils/geturl.ts, updated the example to much simple one.