Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings.yml #5422

Closed
wants to merge 6 commits into from
Closed

Add settings.yml #5422

wants to merge 6 commits into from

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Aug 5, 2022 •
edited
Loading

Blockers: #5418, #5400, an admin of @ethereum installing https://github.com/apps/settings for this repository

Closes #5414

@eth-bot
Copy link
Collaborator

eth-bot commented Aug 5, 2022 •
edited
Loading

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) .github/CODEOWNERS

classification
ambiguous
  • '.github/CODEOWNERS' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

(fail) .github/settings.yml

classification
ambiguous
  • '.github/settings.yml' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

@Pandapip1 Pandapip1 mentioned this pull request Aug 5, 2022
Merged
Pandapip1
Pandapip1 commented Aug 8, 2022
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/settings.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the ambiguous label Aug 8, 2022
@github-actions github-actions bot removed the ambiguous label Aug 8, 2022
@github-actions github-actions bot removed the ambiguous label Aug 8, 2022
@poojaranjan poojaranjan mentioned this pull request Aug 9, 2022
Closed
@Pandapip1 Pandapip1 marked this pull request as ready for review August 11, 2022 01:22
@lightclient
Copy link
Member

I prefer to not use settings.yml. We have had some problems with branch protection in the past and I am not comfortable with someone potentially getting a malicious commit into it.

@Pandapip1
Copy link
Member Author

I'll close this for now, until everything has been settled.

@Pandapip1 Pandapip1 closed this Aug 18, 2022
@Pandapip1 Pandapip1 deleted the use-settings-yml branch August 18, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use settings.yml
4 participants
@Pandapip1 @eth-bot @lightclient @SamWilsn