Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Rewrite index with filters #6483

Closed
wants to merge 5 commits into from

Conversation

fulldecent
Copy link
Contributor

New features:

  • Clear presentation
  • Focus on the content
  • Filters

out

https://youtu.be/gzZqgACuULQ

@eth-bot
Copy link
Collaborator

eth-bot commented Feb 9, 2023

File _data/statuses.yaml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File _includes/eiptable.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File _includes/social.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File _layouts/eip.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File all.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File core.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File erc.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File index.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File informational.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File interface.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File meta.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File networking.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/erc-last-call.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/erc.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/nonerc-last-call.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/nonerc.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 9, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gone over this yet, but I would like to before it's merged.

@fulldecent
Copy link
Contributor Author

Hi @SamWilsn thank you for checking in

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be split into two PRs. One to add the RSS feeds, the other to add filters.

@Pandapip1 Pandapip1 changed the title Rewrite index with filters Website: Rewrite index with filters Feb 12, 2023
@fulldecent
Copy link
Contributor Author

I agree there are two concerns in this PR. Maybe they are related maybe they are not.

Don't anybody have feedback yet on the PR as-is? And either part of it?

@Pandapip1
Copy link
Member

Don't anybody have feedback yet on the PR as-is? And either part of it?

As previously mentionned, the RSS feeds should be a separate PR. I like the idea of filters in concept, but I would prefer it to be a separate page, instead of overriding the readme.

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI errors

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Feb 27, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 27, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0. I like the filters, but I'd rather it not replace the main index.

@fulldecent
Copy link
Contributor Author

@Pandapip1 Is your branch up-to-date? Can I take your index (the rendered static HTML version) and use that in this PR as the homepage? Then I'll move what is currently the homepage here to all.html.

Maybe that's a way to move this PR forward -- and then on a later day separately discuss the merits of the EIPs homepage just being all content.

@Pandapip1
Copy link
Member

@Pandapip1 Is your branch up-to-date? Can I take your index (the rendered static HTML version) and use that in this PR as the homepage? Then I'll move what is currently the homepage here to all.html.

I'm +1 to that.

@fulldecent
Copy link
Contributor Author

May I have the deployed link again please

@Pandapip1
Copy link
Member

@fulldecent
Copy link
Contributor Author

@Pandapip1 got it

You asked me to separate out this part #6579 is that ready to merge now?

@Pandapip1
Copy link
Member

You asked me to separate out this part #6579 is that ready to merge now?

No. It needs one more review.

@SamWilsn
Copy link
Contributor

SamWilsn commented Mar 8, 2023

Will this hurt what little SEO we have?

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the all.html page, since removing it would make the EIPs website significantly harder to index.

@fulldecent
Copy link
Contributor Author

I already committed to restore the index.html here. No need to consider that point in this thread.

However I won't continue on this PR until #6579 merges or somebody tells me "I will support #6483 for merge if you xxxx"

@github-actions github-actions bot added c-new Creates a brand new proposal c-update Modifies an existing proposal s-draft This EIP is a Draft labels Mar 13, 2023
@github-actions github-actions bot removed c-new Creates a brand new proposal c-update Modifies an existing proposal t-core t-erc t-interface t-process s-draft This EIP is a Draft s-review This EIP is in Review s-final This EIP is Final labels Mar 13, 2023
@github-actions
Copy link

The commit 4693f75 (as a parent of 9c72bac) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 13, 2023
Kourouta
Kourouta previously approved these changes Mar 14, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI errors.

add page fragments
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Mar 14, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to replace the all.html page with the filter page, then I request that you re-add the category-specific pages.

Also, there is some linking to those pages that would break, which would also be bad for SEO.

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the RSS feeds are still in this PR.

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jul 24, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants