Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: more rss feeds #6579

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Website: more rss feeds #6579

merged 3 commits into from
Mar 22, 2023

Conversation

fulldecent
Copy link
Contributor

This extracts a feature from: #6483

Now added is multiple RSS feeds. And features RSS feeds on the homepage for:

  • All changes
  • Last Call
  • Everything except ERC

This should be of particular interest to people that think eips.ethereum.org has too many notifications about ERCs.

@github-actions github-actions bot added c-status Changes a proposal's status s-draft This EIP is a Draft t-erc labels Feb 24, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 24, 2023 •
edited
Loading

All reviewers have approved. Auto merging...

@eth-bot eth-bot added a-review Waiting on author to review e-consensus Waiting on editor consensus labels Feb 24, 2023
Pandapip1
Pandapip1 suggested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is EIP-1077 modified?

@Pandapip1 Pandapip1 changed the title Feature: more rss feeds Website: more rss feeds Feb 24, 2023
Pandapip1
Pandapip1 suggested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there are merge conflicts. Please fix them.

@fulldecent fulldecent changed the title Website: more rss feeds Website: more rss feeds [ WIP ] Feb 24, 2023
@github-actions github-actions bot removed c-status Changes a proposal's status t-erc s-draft This EIP is a Draft labels Feb 24, 2023
@fulldecent
Copy link
Contributor Author

@Pandapip1 sorry about that, dumb git mistake, should be fixed now

@fulldecent fulldecent changed the title Website: more rss feeds [ WIP ] Website: more rss feeds Feb 24, 2023
Pandapip1
Pandapip1 previously approved these changes Feb 24, 2023
View reviewed changes
@fulldecent fulldecent mentioned this pull request Mar 1, 2023
Closed
SamWilsn
SamWilsn reviewed Mar 3, 2023
View reviewed changes
index.html Show resolved Hide resolved
rss/erc-last-call.xml Outdated Show resolved Hide resolved
rss/erc.xml Outdated Show resolved Hide resolved
rss/erc.xml Outdated Show resolved Hide resolved
@poojaranjan poojaranjan mentioned this pull request Mar 8, 2023
Closed
9 tasks
fulldecent and others added 2 commits March 9, 2023 15:24
@fulldecent @SamWilsn
Update rss/erc-last-call.xml
a2534bf 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@fulldecent
update anchor and titles
11ee561
@poojaranjan poojaranjan mentioned this pull request Mar 22, 2023
Closed
6 tasks
@eth-bot eth-bot enabled auto-merge (squash) March 22, 2023 14:44
@eth-bot eth-bot merged commit 1ac0fe6 into ethereum:master Mar 22, 2023
@fulldecent
Copy link
Contributor Author

Thank you for the merge!

Now that these RSS feeds are live I have intergrated them into the mailchimp campaigns. Here are some field notes in case we have to do this again some day:

Create an email address and sign up for the signup form using each combination of {Everything, Last call only} x {Everything, EIPonly, ERConly}. This is a workaround for a bug in Mailchimp. This requires having VPN access or friends with other IP addresses.

Create a "campaign" connecting each RSS feed to the appropriate "segment" as described above. Disable link tracking. Fill in required information. Save templates. Use the same template for each. Do not use the "saved segments" feature it is broken if you use adblock, use adhoc segments.

Easy, done, hope it works.

axelcabee pushed a commit to axelcabee/EIPs that referenced this pull request May 6, 2023
@fulldecent @SamWilsn @axelcabee
Website: more rss feeds (ethereum#6579)
54ac09f 
* add rss feeds

* Update rss/erc-last-call.xml

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* update anchor and titles

---------

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@fulldecent @SamWilsn @GAEAlimited
Website: more rss feeds (ethereum#6579)
ff35945 
* add rss feeds

* Update rss/erc-last-call.xml

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* update anchor and titles

---------

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@timbeiko timbeiko timbeiko left review comments

@eth-bot eth-bot eth-bot approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
a-review Waiting on author to review e-consensus Waiting on editor consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fulldecent @eth-bot @timbeiko @lightclient @Pandapip1 @SamWilsn