Add EIP: Revert creation in case of collision #6733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All reviewers have approved. Auto merging... |
eth-bot
added
e-consensus
github-actions
bot
added
c-new
SamWilsn
reviewed
Mar 21, 2023
abcoathup
reviewed
Mar 21, 2023
h4l
reviewed
Mar 21, 2023
h4l
reviewed
Mar 21, 2023
|
The commit e9e3773 (as a parent of c57947a) contains errors. |
Pandapip1
suggested changes
Mar 22, 2023
eth-bot
changed the title
Test case address correction
lightclient
previously requested changes
Mar 23, 2023
There was a problem hiding this comment.
This was already specified in EIP-684, but was not created moved into an EIP markdown document. If you'd like to resolve this, I would prefer to pick up from there (which will also resolve #2220).
|
@lightclient yes, how do we proceed? |
|
Please convert that EIP into a mark down file and push to final. |
Hey @lightclient, one thing that is not clear to me is, do I put my text in that eip or do I recollect what is there? |
|
New PR on #6784 |
Pandapip1
approved these changes
Mar 27, 2023
github-actions
bot
added
s-final
eth-bot
approved these changes
Mar 27, 2023
axelcabee
pushed a commit
to axelcabee/EIPs
that referenced
this pull request
May 6, 2023
* EIP contract collision * Update discussion link * Grammar fix, EIP number * linter fixes * internal link fix * Inclusion of suggestions Test case address correction * accept suggestions, address correction * some changes * second address correction * Update and rename eip-6733.md to eip-684.md * Update eip-684.md --------- Co-authored-by: Gavin John <gavinnjohn@gmail.com>
RaphaelHardFork
pushed a commit
to RaphaelHardFork/EIPs
that referenced
this pull request
Jan 30, 2024
* EIP contract collision * Update discussion link * Grammar fix, EIP number * linter fixes * internal link fix * Inclusion of suggestions Test case address correction * accept suggestions, address correction * some changes * second address correction * Update and rename eip-6733.md to eip-684.md * Update eip-684.md --------- Co-authored-by: Gavin John <gavinnjohn@gmail.com>
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
* EIP contract collision * Update discussion link * Grammar fix, EIP number * linter fixes * internal link fix * Inclusion of suggestions Test case address correction * accept suggestions, address correction * some changes * second address correction * Update and rename eip-6733.md to eip-684.md * Update eip-684.md --------- Co-authored-by: Gavin John <gavinnjohn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: