Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-6538: Move to Review #259

Merged
merged 26 commits into from
Apr 9, 2024

Conversation

garyghayrat
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 14, 2024

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Update ERC-6538: Move to Review with updated contracts, security considerations, and deployment method Update ERC-6538: Move to Review Feb 14, 2024
Copy link
Contributor

@nerolation nerolation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@gaudren gaudren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You could expand a bit on technical details in your Abstract section.
  • The Reference Implementation section seems unnecessary.
  • This EIP cannot be merged with MIT licenses.

ERCS/erc-6538.md Outdated Show resolved Hide resolved
ERCS/erc-6538.md Show resolved Hide resolved
ERCS/erc-6538.md Outdated Show resolved Hide resolved
ERCS/erc-6538.md Outdated Show resolved Hide resolved
ERCS/erc-6538.md Outdated Show resolved Hide resolved
ERCS/erc-6538.md Outdated Show resolved Hide resolved
ERCS/erc-6538.md Outdated Show resolved Hide resolved
ERCS/erc-6538.md Outdated Show resolved Hide resolved
ERCS/erc-6538.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 5, 2024

The commit fd01eb7 (as a parent of cccb3ed) contains errors.
Please inspect the Run Summary for details.

ERCS/erc-6538.md Outdated Show resolved Hide resolved
@eip-review-bot eip-review-bot enabled auto-merge (squash) April 9, 2024 15:33
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 99a1db2 into ethereum:master Apr 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants