Moves 7409 to final. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit b6edb5d (as a parent of 9e649bb) contains errors. |
|
@lightclient I think this is failing when parsing erc-template. Neither my change, nor my ERC have the reported problem. |
|
@steven2308 looking into it, thx. |
lightclient
approved these changes
Oct 25, 2023
SamWilsn
added a commit
that referenced
this pull request
Mar 5, 2024
* Update erc-7007.md to add opML compatibility (#1) * Update erc-7007.md to add opML compatibility * Update erc-7007.md param name * Create IOpmlLib.sol * Update and rename ERC7007.sol to ERC7007_zkml.sol * Update IOpmlLib.sol * Update IOpmlLib.sol * Update IOpmlLib.sol * Create ERC7007_opml.sol * Update ERC7007_opml.sol * Update IOpmlLib.sol * feat: update implementation to include owner address * feat: update authorship, added Updatable extension, update metadata with `proof_type` * fix: full term before abbreviation * feat: Update ERC7007 contracts and add IERC7007Updatable interface * feat: Add rationale and security considerations * feat: `update` function to use `verify` in `require` statement * misc: capitalization * xhyu patch 1 (#2) * misc: improve abstract & motivation * fix: Spec intro & Model Publication wording * fix: Rewrite part of motivation * corrected some small typos * rewrote the last two paragraphs in Motivation --------- Co-authored-by: drCathieSo.eth <socathie@users.noreply.github.com> * fix: proposal reference and header * fix: file references * Update erc-7007.md: Fix wordings (#4) * Update erc-7007.md: Fix wordings * update license * Update description and motivation -> rationale --------- Co-authored-by: drCathieSo.eth <socathie@users.noreply.github.com> * Add workflow (#5) * Add workflow diagram * Add workflow description * Apply suggestions from code review Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update erc-7007.md * Fix uppercase keywords * Update erc-7007.md --------- Co-authored-by: 李婷婷 Lee Ting Ting <tina1998612@users.noreply.github.com> Co-authored-by: xhyumiracle <xhyumiracle@gmail.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.