Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sha256 built-in function #19

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Use sha256 built-in function #19

merged 2 commits into from
Apr 15, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 7, 2019 •
edited
Loading

What was wrong?

(In discussion) test replacing keccak256 sha256.

How was it fixed?

The test can pass with vyperlang/vyper#1331 in my local side 🐍

Gas cost

Gas cost:

tests/contracts/test_deposit.py::test_deposit_tree
deposit transaction consumes 197128 gas
deposit transaction consumes 168772 gas
deposit transaction consumes 167138 gas
deposit transaction consumes 170416 gas
deposit transaction consumes 167138 gas
deposit transaction consumes 168782 gas
deposit transaction consumes 167148 gas
deposit transaction consumes 172060 gas
deposit transaction consumes 167138 gas
deposit transaction consumes 168782 gas

~3k less than the workaround (#14) 🎉🎉

Cute Animal Picture

love-pet-kitten-cat-mammal-companionship-friendship-together-fauna-whiskers-friends-vertebrate-domestic-trust-adorable-cat-and-dog-cats-and-dogs-dog-and-cat-together-small-to-medium-sized-cats-cat-like-mammal-dog-breed-group-656221

@hwwhww hwwhww mentioned this pull request Mar 7, 2019
Merged
@hwwhww hwwhww changed the title Use sha256 built-in function [DO NOT MERGE] Use sha256 built-in function Mar 7, 2019
@hwwhww hwwhww mentioned this pull request Mar 14, 2019
Closed
@jacqueswww
Copy link

jacqueswww commented Mar 14, 2019 •
edited
Loading

@hwwhww I just remembered! I cut release for b9 if that's is what you were waiting for :) hope you have a great day/evening!

@NIC619 NIC619 changed the base branch from master to dev March 26, 2019 14:08
@hwwhww hwwhww changed the title [DO NOT MERGE] Use sha256 built-in function Use sha256 built-in function Mar 27, 2019
@hwwhww hwwhww requested a review from NIC619 March 27, 2019 06:28
@NIC619 NIC619 merged commit 8749c60 into ethereum:dev Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NIC619 NIC619 NIC619 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwwhww @jacqueswww @NIC619