Add sha256 function #1331
Merged
Add sha256 function #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hwwhww So I managed to get it done today :) would you perhaps be able to test it? |
|
Thank you so much @jacqueswww! The tests of ethereum/deposit_contract#19 passed with this branch. |
|
Cool! @charles-cooper @fubuloubu I think we are OK merging this? I don't think there is much to discuss on the VIP ? |
|
I'm fine with that |
charles-cooper
requested changes
Mar 7, 2019
There was a problem hiding this comment.
@jacqueswww Including sha256 seems fine to me, I left a couple comments about implementation details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes #1327.
How I did it
How to verify it
Description for the changelog
Cute Animal Picture