deps: update influxdb #26928
Closed
deps: update influxdb #26928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems our old dependency pulled in the entire influxdb repo because back then the client was embedded inside. Since then the client is it's separate project and we should switch over to depending on that only. To make things more fun however, this is the client for Influx 2 (and maybe 1.8 and above) https://github.com/influxdata/influxdb-client-go and this is for below that https://github.com/influxdata/influxdb1-client I'm unsure which we would need to use honestly. Nor whether we should use both and somehow dynamically switch (based on what?). It might also screw up the flags if authentication changes. |
|
Ha,
|
|
I'll close this and try a different attempt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #26926 , to see what it is that pulls in
golang.org/x/net@0.4.0, I noticed that out influx dependency is very old, atv1.8.3when the latest isv1.11.0.Updates since
It just continues. There's a lot of fixes. After a while, they stopped making big 'releases', and just did the "tag and done", e.g. v1.10.0 release: https://github.com/influxdata/influxdb/releases/tag/v1.10.0 and 11: https://github.com/influxdata/influxdb/releases/tag/v1.11.0
And no, this PR still does not update
golang.org./x/net