metrics/influxdb: update dependency #26937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used this PR to run geth No obvious errors |
|
Swapping this in on |
|
Everything LGTM (15 minutes with a different PR, and 15 minutes with this PR: https://geth-bench.ethdevops.io/d/Jpk-Be5Wk/dual-geth?var-exp=bench07&var-master=bench07&var-percentile=50&from=1679568700769&to=1679570615983 ) |
fjl
reviewed
Mar 23, 2023
| @@ -21,7 +21,7 @@ type reporter struct { | |||
| namespace string | |||
| tags map[string]string | |||
|
|
|||
| client *client.Client | |||
| client client.Client | |||
|
|
|||
| cache map[string]int64 | |||
There was a problem hiding this comment.
I think this field is not used anymore
There was a problem hiding this comment.
What do you mean? It's used in both Ping and send
case <-pingTicker.C:
_, _, err := r.client.Ping(0)
return r.client.Write(bps)
fjl
approved these changes
Mar 23, 2023
|
Closed in favour of #26963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #26928 . Instead of upgrading the whole influx package, it switches to use the smaller
influxdata/influxdb1-clientpackage.For influxdb-v2, we already use the smaller client package, so this change removes the large dependency.
There are some api-changes in the handlng of points batch, and this PR needs to be tested in prod.