all: implement EIP-7002 and EIP-7251, execution layer triggered withdrawal and consolidation requests #29052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an upper limit on exits? |
|
The max number of deposits is in the system contract and is 16 currently. |
lightclient
changed the title
lightclient
force-pushed
the
eip-7002
branch
6 times, most recently
from
7808812
to
653d0bc
Compare
lightclient
force-pushed
the
eip-7002
branch
10 times, most recently
from
4fa354b
to
30e7f7b
Compare
lightclient
requested review from
holiman,
s1na,
gballet,
karalabe and
rjl493456442
as code owners
lightclient
force-pushed
the
eip-7002
branch
3 times, most recently
from
e45f9a4
to
e89e120
Compare
lightclient
force-pushed
the
eip-7002
branch
2 times, most recently
from
7282500
to
0cb192e
Compare
lightclient
force-pushed
the
eip-7002
branch
5 times, most recently
from
aaa5954
to
9d87ac7
Compare
Imrall
approved these changes
Sep 7, 2024
lightclient
force-pushed
the
eip-7002
branch
from
9d87ac7
to
3fbf9ff
Compare
Co-authored-by: Mario Vega <marioevz@gmail.com> Co-authored-by: lightclient <lightclient@protonmail.com>
lightclient
force-pushed
the
eip-7002
branch
from
3fbf9ff
to
3aae627
Compare
|
|
||
| // Parse out the exits. | ||
| var reqs types.Requests | ||
| for i := 0; i < len(ret)/76; i++ { |
There was a problem hiding this comment.
Should we check that ret is % 76 == 0 here or just accept anything thats returned from the contract?
|
Note that work on the spec is still ongoing, and we will have some simplifications in soon that will invalidate most of this PR. |
lightclient
changed the title
|
I have created a new implementation in #30571 since it is so much simpler now. There was just no point trying to rebase this one. |
fjl
added a commit
that referenced
this pull request
Oct 11, 2024
This is a redo of #29052 based on newer specs. Here we implement EIPs scheduled for the Prague fork: - EIP-7002: Execution layer triggerable withdrawals - EIP-7251: Increase the MAX_EFFECTIVE_BALANCE Co-authored-by: lightclient <lightclient@protonmail.com>
holiman
pushed a commit
that referenced
this pull request
Oct 13, 2024
This fixes a few issues missed in #29052: * `requests` must be hex encoded, so added a helper to marshal. * The statedb was committed too early and so the result of the system calls was lost. * For devnet-4 we need to pull off the type byte prefix from the request data.
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
This is a redo of #29052 based on newer specs. Here we implement EIPs scheduled for the Prague fork: - EIP-7002: Execution layer triggerable withdrawals - EIP-7251: Increase the MAX_EFFECTIVE_BALANCE Co-authored-by: lightclient <lightclient@protonmail.com>
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
This fixes a few issues missed in #29052: * `requests` must be hex encoded, so added a helper to marshal. * The statedb was committed too early and so the result of the system calls was lost. * For devnet-4 we need to pull off the type byte prefix from the request data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the 6110 impl #29431merged!This PR implements EIP-7002: Execution layer triggerable exits and EIP-7251: Increase the MAX_EFFECTIVE_BALANCE