cmd/evm: fixup issues with requests in t8n #30584
Merged
+167
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
requested review from
holiman and
MariusVanDerWijden
as code owners
holiman
reviewed
Oct 13, 2024
|
|
||
| // Gather the execution-layer triggered requests. | ||
| var requests [][]byte | ||
| if chainConfig.IsPrague(vmContext.BlockNumber, vmContext.Time) { |
There was a problem hiding this comment.
Interesting that this processing is placed after the block rewards. The spec doesn't explicitly say which ("at end end of") is correct, and it doesn't matter, since neither of these syscalls are influenced by the balances.
If they were, one could use the block reward to trigger some diff between two clients that had a different order.
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
This fixes a few issues missed in #29052: * `requests` must be hex encoded, so added a helper to marshal. * The statedb was committed too early and so the result of the system calls was lost. * For devnet-4 we need to pull off the type byte prefix from the request data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues I missed in #29052.
requestsmust be hex encoded, so added a helper to marshal.