Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint 2 spaces fix #3939

Merged
merged 10 commits into from
Jul 24, 2023
Merged

Eslint 2 spaces fix #3939

merged 10 commits into from
Jul 24, 2023

Conversation

bunsenstraat
Copy link
Collaborator

@bunsenstraat bunsenstraat commented Jul 23, 2023

We have incosistent indentation in the project, some files use 1 space, some 2, some 4.
Most commonly used throughout the project is 2.
sets all indentation on code files ( ts, tsx, js, jsx ) to 2 spaces
created a lint-fix-targets.js script to fix it
set eslint rule to enforce

if a change is needed, just change the eslint base file and run node lint-fix-targets.js

@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 866cc44
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/64be51d4985a650008e05a5e
😎 Deploy Preview https://deploy-preview-3939--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bunsenstraat bunsenstraat changed the title Eslint Eslint 2 spaces fix Jul 23, 2023
@bunsenstraat bunsenstraat self-assigned this Jul 23, 2023
Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @bunsenstraat

@bunsenstraat bunsenstraat merged commit abc6101 into master Jul 24, 2023
@bunsenstraat bunsenstraat deleted the eslint branch July 24, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants