Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler incorrectly reasons about the selector function #3494

Closed
fulldecent opened this issue Feb 13, 2018 · 5 comments
Closed

Compiler incorrectly reasons about the selector function #3494

fulldecent opened this issue Feb 13, 2018 · 5 comments
Assignees
@chriseth
Labels
bug 🐛

Comments

@fulldecent
Copy link
Contributor

screen shot 2018-02-13 at 1 16 21 am
screen shot 2018-02-13 at 1 16 34 am
@chriseth chriseth self-assigned this Feb 13, 2018
@chriseth
Copy link
Contributor

That's a tricky one. Of course this.f.selector should be fine, and even this.f should be fine. The problem is that this is disallowed in a view context - reading the current address is not a pure action.

@fulldecent
Copy link
Contributor Author

Thank you.

At a minimum, can we a get a "this should be fixed someday" on this issue.

I am more interested in this issue being accepted and less interested in the actual fix. I think you know why...

@chriseth chriseth mentioned this issue Feb 13, 2018
Merged
@fulldecent
Copy link
Contributor Author

fulldecent commented Feb 13, 2018 •
edited
Loading

Wow, that was much faster than I hoped. Thanks!

@aion82
Copy link

aion82 commented Feb 14, 2018

ok

@chriseth
Copy link
Contributor

Some things are easy, some not so much :)

@fulldecent fulldecent mentioned this issue Feb 16, 2018
Merged
14 tasks
kophyo1234 added a commit to kophyo1234/openzeppelin-contracts that referenced this issue Jan 29, 2022
@kophyo1234
DOG
07186c3 
Standards

ERC-20 Token Standard.
ERC-165 Standard Interface Detection.
ERC-173 Owned Standard.
ERC-223 Token Standard.
ERC-677 transferAndCall Token Standard.
ERC-827 Token Standard.
Ethereum Name Service (ENS). https://ens.domains
Instagram – What’s the Image Resolution? https://help.instagram.com/1631821640426723
JSON Schema. https://json-schema.org/
Multiaddr. https://github.com/multiformats/multiaddr
RFC 2119 Key words for use in RFCs to Indicate Requirement Levels. https://www.ietf.org/rfc/rfc2119.txt
Issues

The Original ERC-721 Issue. ethereum/EIPs#721
Solidity Issue OpenZeppelin#2330 – Interface Functions are External. ethereum/solidity#2330
Solidity Issue OpenZeppelin#3412 – Implement Interface: Allow Stricter Mutability. ethereum/solidity#3412
Solidity Issue OpenZeppelin#3419 – Interfaces Can’t Inherit. ethereum/solidity#3419
Solidity Issue OpenZeppelin#3494 – Compiler Incorrectly Reasons About the selector Function. ethereum/solidity#3494
Solidity Issue OpenZeppelin#3544 – Cannot Calculate Selector of Function Named transfer. ethereum/solidity#3544
CryptoKitties Bounty Issue OpenZeppelin#4 – Listing all Kitties Owned by a User is O(n^2). dapperlabs/cryptokitties-bounty#4
OpenZeppelin Issue OpenZeppelin#438 – Implementation of approve method violates ERC20 standard. OpenZeppelin#438
Solidity DelegateCallReturnValue Bug. https://solidity.readthedocs.io/en/develop/bugs.html#DelegateCallReturnValue
Discussions

Reddit (announcement of first live discussion). https://www.reddit.com/r/ethereum/comments/7r2ena/friday_119_live_discussion_on_erc_nonfungible/
Gitter #EIPs (announcement of first live discussion). https://gitter.im/ethereum/EIPs?at=5a5f823fb48e8c3566f0a5e7
ERC-721 (announcement of first live discussion). ethereum/EIPs#721 (comment)
ETHDenver 2018. https://ethdenver.com
NFT Implementations and Other Projects

CryptoKitties. https://www.cryptokitties.co
0xcert ERC-721 Token. https://github.com/0xcert/ethereum-erc721
Su Squares. https://tenthousandsu.com
Decentraland. https://decentraland.org
CryptoPunks. https://www.larvalabs.com/cryptopunks
DMarket. https://www.dmarket.io
Enjin Coin. https://enjincoin.io
Ubitquity. https://www.ubitquity.io
Propy. https://tokensale.propy.com
CryptoKitties Deployed Contract. https://etherscan.io/address/0x06012c8cf97bead5deae237070f9587f8e7a266d#code
Su Squares Bug Bounty Program. https://github.com/fulldecent/su-squares-bounty
XXXXERC721. https://github.com/fulldecent/erc721-example
ERC721ExampleDeed. https://github.com/nastassiasachs/ERC721ExampleDeed
Curio Cards. https://mycuriocards.com
Rare Pepe. https://rarepepewallet.com
Auctionhouse Asset Interface. https://github.com/dob/auctionhouse/blob/master/contracts/Asset.sol
OpenZeppelin SafeERC20.sol Implementation. https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/token/ERC20/SafeERC20.sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriseth chriseth

Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fulldecent @chriseth @LianaHus @aion82