Allow this.f.selector to be pure.
#3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
allowthisfselector
branch
from
4418f9a
to
5916cf1
Compare
axic
reviewed
Feb 13, 2018
| if (Declaration const* declaration = expr->annotation().referencedDeclaration) | ||
| { | ||
| u256 identifier; | ||
| if (auto const* variable = dynamic_cast<VariableDeclaration const*>(declaration)) |
There was a problem hiding this comment.
Hm I wonder if we actually want to support .selector on public variables. I don't think we had test cases for that before.
There was a problem hiding this comment.
shall I add a test case?
There was a problem hiding this comment.
It works. I will add a test case.
axic
reviewed
Feb 13, 2018
| @@ -6904,15 +6904,7 @@ BOOST_AUTO_TEST_CASE(function_types_sig) | |||
| CHECK_ERROR(text, TypeError, "Member \"selector\" not found"); | |||
| text = R"( | |||
| contract C { | |||
| function f() view external returns (bytes4) { | |||
There was a problem hiding this comment.
Why did we had a duplicate case here? :)
Perhaps something was lost during rebases.
There was a problem hiding this comment.
I think one of the cases used var before but we removed that and now they are identical.
|
Updated. |
|
Fails on end-to-end tests. |
chriseth
force-pushed
the
allowthisfselector
branch
from
96b7ab7
to
aea9e7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3494