Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined order of functions when generating code for index expressions #14374

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

cameel
Copy link
Member

@cameel cameel commented Jun 28, 2023

Fixes #14361.

@cameel cameel requested a review from nikola-matic June 28, 2023 14:31
@cameel cameel self-assigned this Jun 28, 2023
ekpyron
ekpyron previously approved these changes Jul 10, 2023
Changelog.md Outdated Show resolved Hide resolved
@cameel cameel force-pushed the fix-non-deterministic-ir-function-generation-order branch from 7b9303c to 8e426c7 Compare July 11, 2023 13:37
ekpyron
ekpyron previously approved these changes Jul 11, 2023
Changelog.md Outdated Show resolved Hide resolved
@cameel cameel force-pushed the fix-non-deterministic-ir-function-generation-order branch from 8e426c7 to bda76a1 Compare July 11, 2023 13:54
Changelog.md Outdated Show resolved Hide resolved
@cameel cameel force-pushed the fix-non-deterministic-ir-function-generation-order branch from bda76a1 to a57a7c2 Compare July 13, 2023 09:00
@cameel cameel force-pushed the fix-non-deterministic-ir-function-generation-order branch from a57a7c2 to 5b70830 Compare July 13, 2023 09:08
@cameel cameel requested a review from matheusaaguiar July 13, 2023 09:09
@cameel cameel merged commit 3fc2ead into develop Jul 13, 2023
@cameel cameel deleted the fix-non-deterministic-ir-function-generation-order branch July 13, 2023 10:20
Copy link
Collaborator

@nikola-matic nikola-matic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, just saw you merged this.

@@ -17,6 +17,7 @@ Compiler Features:


Bugfixes:
* Code Generator: Fix not entirely deterministic order of functions in unoptimized Yul output. The choice of C++ compiler in some cases would result in different (but equivalent) bytecode (especially from native binaries vs emscripten binaries)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Code Generator: Fix not entirely deterministic order of functions in unoptimized Yul output. The choice of C++ compiler in some cases would result in different (but equivalent) bytecode (especially from native binaries vs emscripten binaries)
* Code Generator: Fix not entirely deterministic order of functions in unoptimized Yul output. The choice of C++ compiler in some cases would result in different (but equivalent) bytecode (especially from native binaries vs emscripten binaries).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we can still fix this when we sort the changelog before release. If this was a bigger mistake I'd push a new PR, but for a dot it's not worth it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants