Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Eldarica on Ubuntu Clang images #14976

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Apr 3, 2024

I forgot to add Eldarica to the ubuntu-clang images, and those run the tests with smt enable on nightly builds: https://app.circleci.com/pipelines/github/ethereum/solidity/33569/workflows/26e587dd-8b83-4b93-ba99-dc0f98d4910c/jobs/1512378. This PR fix that.

Copy link

github-actions bot commented Apr 3, 2024

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204.clang-6 [solbuildpackpusher/solidity-buildpack-deps@sha256:1818a56061f39ece4a92138948404214bf939c9deb68f4dc2c68cd82b39e8410].

Copy link

github-actions bot commented Apr 3, 2024

solbuildpackpusher/solidity-buildpack-deps:ubuntu.clang.ossfuzz-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:c21c4c2a591d0702c388d1944539f6498ed8e51c54c1a1cb34693079efd9ab77].

@r0qs r0qs mentioned this pull request Apr 3, 2024
@blishko blishko merged commit 0289bb2 into develop Apr 3, 2024
79 checks passed
@blishko blishko deleted the eldarica-ubuntu-clang-images branch April 3, 2024 13:32
Comment on lines 148 to +153
rm -rf /usr/src/Yul-Isabelle

# Cleanup
RUN set -ex; \
rm -rf /var/lib/apt/lists/*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleanup is actually both superfluous and ineffective.

Thanks to the FROM base bit below we discard everything except for a few selected dirs anyway so we don't need to worry about cleaning up anywhere outside of these dirs.

And if we weren't doing that, removing stuff in a separate RUN command would not really remove it from the image. It would still be in the original layer and just marked as removed by layer above, but still taking up space.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. Didn't know that. We can remove those then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants