Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install python dependencies on buildpack-deps images #15059

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Install python dependencies on buildpack-deps images #15059

merged 3 commits into from
Apr 26, 2024

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Apr 26, 2024 •
edited
Loading

Install python packages and other common dependencies used by Linux machines on docker buildpack-deps images.

The PR also split the installation commands by line and sorts the packages by name, so we can easily detect changes and duplicates (note that git was duplicated in one of the dockerfiles).

And it also removes a superfluous cleanup step from previous PR, see: #14976 (comment)

@r0qs r0qs force-pushed the add-python-pkgs-buildpack-deps branch from 15474a5 to 351a910 Compare April 26, 2024 12:44
@r0qs r0qs mentioned this pull request Apr 26, 2024
Merged
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@r0qs
Copy link
Member Author

r0qs commented Apr 26, 2024

See commit 351a910 to clearly identify what was added and removed. The other commits are aesthetic only.

@r0qs r0qs requested a review from cameel April 26, 2024 15:13
@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204.clang-7 [solbuildpackpusher/solidity-buildpack-deps@sha256:0f47e733e100080c4174381c262cfcf974bc8e7c3c41b8dff611b9641c82f714].

@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204-8 [solbuildpackpusher/solidity-buildpack-deps@sha256:1c3a4118218640b2bf632242979a63d48f3d9c70d48be9574332f2dbbd04b192].

@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu.clang.ossfuzz-6 [solbuildpackpusher/solidity-buildpack-deps@sha256:8883fa2845bbc1e0922af60439313666e4ba325f67a117e17d78cca3ea6589b3].

@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:emscripten-17 [solbuildpackpusher/solidity-buildpack-deps@sha256:c57f2bfb8c15d70fe290629358dd1c73dc126e3760f443b54764797556b887d4].

@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-23 [solbuildpackpusher/solidity-buildpack-deps@sha256:84a1fb8771236e8d9aa5c615a425b8929e56a6e4f150a60078c8d74a1ceaa6c2].

cameel
cameel approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please only merge it if CI in #15060 actually passes. Both PRs should be merged together.

@r0qs
Copy link
Member Author

r0qs commented Apr 26, 2024

Approving, but please only merge it if CI in #15060 actually passes. Both PRs should be merged together.

I'm also testing the nightly builds here: https://app.circleci.com/pipelines/github/ethereum/solidity?branch=test-nightly to avoid any surprise tomorrow hahaha

@r0qs
Copy link
Member Author

r0qs commented Apr 26, 2024

Approving, but please only merge it if CI in #15060 actually passes. Both PRs should be merged together.

Ok everything seems to pass with exception of the usual t_ubu_ossfuzz regression test that always fails. So I'm merging it ;)

@r0qs r0qs merged commit 7f88baa into develop Apr 26, 2024
78 checks passed
@r0qs r0qs deleted the add-python-pkgs-buildpack-deps branch April 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel approved these changes

Assignees
No one assigned
Labels
build system 🏗️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r0qs @cameel