[ECIP-1054] Move Atlantis to Final, Add EIP-684

[soc1c]

Moves Atlantis to FINAL, closes #67

Adds missing EIP-684, ref ethereum/EIPs#2220 and ethereum/EIPs#2252

[saturn-network]

Welcome to Atlantis! Thank you everyone for the hard work of pushing this project over the finish line

[sorpaas]

EIP 684 applies retroactively starting from genesis. It should not has a hard fork number, and thus I don't believe it belongs here.

[GregTheGreek]

EIP 684 applies retroactively starting from genesis. It should not has a hard fork number, and thus I don't believe it belongs here.

Where would it go? This is an ongoing discussion on ETH - it should definitely be added to the Atlantis META. Similarly it should be added to the Byzantium META

[sorpaas]

@GregTheGreek I still don't quite believe that 684 was the impact for the previous Classic Geth bug. The issue is that it shouldn't really affect anything before CREATE2. I think some information might have been mixed up in the process of that bug fix.

[GregTheGreek]

I do agree, I don't think it was the root of the bug.
Nonetheless this still should be in the Atlantis meta, we don't need to follow the ETH eip process 1-for-1.

[sorpaas]

@GregTheGreek If we agree that 684 wasn't the cause for any consensus bugs, then I believe my original argument stands. This is something that retroactively applies to genesis, and it does not fit into a Meta ECIP with a hard fork number. However, we should use a separate documentation to note that 684 is in effect.

[sorpaas]

I created #142 to address the issue of 684.