Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECIP-1104] BASEFEE omit, activations, last call #452

Merged
merged 8 commits into from
Jan 6, 2022

Conversation

diega
Copy link
Contributor

@diega diega commented Dec 8, 2021

This PR proposes the following changes:

  • Exclude EIP-3198: BASEFEE Opcode from Mystique
  • Add block number activation for each network based on the following calculations
    • Mordor (1587460 seconds until Jan 10th 2022): 5_294_406 block + 1_587_460 secs / 13.3 secs/block ~= 5_414_000 block
    • Kotti (2449694 seconds until Jan 20th 2022): 5_395_501 block + 2_449_694 secs / 15 secs/block ~= 5_559_000 block
    • Mainnet (4264005 seconds until Feb 10th 2022): 14_181_120 block + 4_264_005 secs / 13.3 secs/block ~= 14_502_000 block
  • Change ECIP status to Last call

Ref: discussion #440

@diega
Copy link
Contributor Author

diega commented Dec 8, 2021

cc: @ziogaschr @meowsbits @iquidus

@bobsummerwill
Copy link
Member

Typo - "This opcode is being added to ensure alignement with evm standards but will not be used on chain."

Should be "alignment".

@meowsbits
Copy link
Member

meowsbits commented Dec 9, 2021

Is 10.5 secs/block for Mordor accurate?

@diega
Copy link
Contributor Author

diega commented Dec 9, 2021

Is 10.5 secs/block for Mordor accurate?

It seems to be pretty erratic, I took it yesterday from Blockscout, but now it's at 15.4 secs/block. Do you think this value is more accurate?

@meowsbits
Copy link
Member

I was mostly just wondering about exactly that; the variance, and where the estimate came from.
If we assume the true value is somewhere between the numbers you've cited, the actual time of forking hits a little later than Dec 15th. It won't hurt to have a little bonus time to get upgraded.

@diega diega changed the title [ECIP-1104] BASEFEE spec, activations, last call [ECIP-1104] BASEFEE omit, activations, last call Dec 22, 2021
_specs/ecip-1104.md Outdated Show resolved Hide resolved
Co-authored-by: meowsbits <b5c6@protonmail.com>
_specs/ecip-1104.md Outdated Show resolved Hide resolved
good catch!

Co-authored-by: meowsbits <b5c6@protonmail.com>
@meowsbits meowsbits requested review from realcodywburns and a team January 6, 2022 17:13
@bobsummerwill bobsummerwill merged commit af53d4b into ethereumclassic:master Jan 6, 2022
@diega diega deleted the 1104_last_call branch January 17, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants