Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ECIP-1104 to status Accepted #459

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Move ECIP-1104 to status Accepted #459

merged 1 commit into from
Jan 17, 2022

Conversation

diega
Copy link
Contributor

@diega diega commented Jan 17, 2022

I propose to accept the current state of the ECIP

@bobsummerwill
Copy link
Member

I do not have permissions to review, but I agree with the change.

meowsbits
meowsbits approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@meowsbits meowsbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe Accepted can only be applied 2 weeks after the move to Last Call.

@diega
Copy link
Contributor Author

diega commented Jan 17, 2022

Excellent. Last Call was set 11 days ago in #452. I think we can wait 3 more days

@bobsummerwill
Copy link
Member

That makes sense to me, yes.

@bobsummerwill
Copy link
Member

Actually, I see no real benefit in waiting just to hit that arbitrary 14 day point, so I will merge now.
That will help with the adoption.

@bobsummerwill bobsummerwill merged commit 622edfb into ethereumclassic:master Jan 17, 2022
@diega diega deleted the 1104_accepted branch January 17, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowsbits meowsbits meowsbits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diega @bobsummerwill @meowsbits