This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Fix: Replace toBuffer with toArrayLike #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpulim
changed the title
holgerd77
approved these changes
Oct 25, 2018
|
(@vpulim you can actually also prepare releases yourself and do a PR with version number change + CHANGELOG if you need one somewhere, I will then review + publish on npm) |
|
@holgerd77 Thanks for the review. Yes, this would be a minor patch release (3.3.1) that allows ethereumjs-blockchain to be transpiled correctly with browserify. This fix is required in order for ethereumjs-client to run in the browser. It's a similar fix to: ethereumjs/ethereumjs-monorepo#163 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue with browserify: indutny/bn.js#147