replace toBuffer => toArrayLike #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
here is more details about the issue indutny/bn.js#147
|
Oh seems like this is the only case left using |
axic
approved these changes
Aug 1, 2017
axic
reviewed
Aug 1, 2017
| @@ -71,7 +71,7 @@ module.exports = function (opts, cb) { | |||
| stateManager.getAccount(createdAddress, function (err, account) { | |||
| toAccount = account | |||
| const NONCE_OFFSET = 1 | |||
| toAccount.nonce = new BN(toAccount.nonce).addn(NONCE_OFFSET).toBuffer() | |||
| toAccount.nonce = new BN(toAccount.nonce).addn(NONCE_OFFSET).toArrayLike(Buffer) | |||
There was a problem hiding this comment.
Actually, hold on a second. We need to define the endianess and size of the nonce field. Probably toArrayLike(Buffer, 'be') is the correct one, because RLP will remove the zeroes anyway.
There was a problem hiding this comment.
@axic I think if toBuffer worked correct, toArrayLike(Buffer) also will work correct
There was a problem hiding this comment.
Right, because it defualts to be and RLP will remove any leading zeroes.
holgerd77
added a commit
that referenced
this pull request
Mar 11, 2021
Pin ethjs-util version exactly
holgerd77
added a commit
that referenced
this pull request
May 26, 2023
Added verifyPublicKey to verify publicKey, privateKey pair.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here is more details about the issue indutny/bn.js#147