This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Fix levelup NotFoundError handling #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
holgerd77
approved these changes
Jan 3, 2019
|
Can you also prepare a PR towards the VM? We should also update the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM tests are failing on the
iteratemethod ofBlockchain. I think the reason is different versions oflevelupbeing used in the two projects. VM passes itsdbto Blockchain, which checks the error byerr instanceof level.errors.NotFoundErroron a more recent version oflevelup.The modified condition seems to work, but it's probably a good idea to update
levelupin VM as well.