Upgrade ethereumjs-blockchain and level #414
Conversation
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com> - Upgrade ethereumjs-blockchain to v3.3.3 - Upgrade devDeps to level v4.0.0 and level-mem v3.0.1 - Fix level dep in api tests
s1na
force-pushed
the
chore/upgrade-level
branch
from
bc49539
to
68a28e8
Compare
There was a problem hiding this comment.
Looks good, thanks! 😄
Hmm, what would be a good release strategy for this? Maybe bump the minor version - to make this somewhat more visible - and recommend in the release notes to update level instances (indirectly) passed?
(maybe we should have been doing this on the blockchain library as well, but anyhow)
|
@s1na won't merge since this is so new, but feel free to do so if you think it's ready from your side! |
|
@holgerd77 Maybe we can bundle this with other PRs in one release? This PR by itself mostly is relevant for development purposes and users of the library shouldn't need to change anything. Maybe we can ask for someone else to also have a look, just to be sure? |
|
Yes, wouldn't make an extra release just for this. Will merge for now. |
This PR upgrades ethereumjs-blockchain to v3.3.3 to fix failing tests, level to v4.0.0 and level-mem to v3.0.1.
Level libraries are dev dependencies and are only used in tests directly.