There is a typo on index.js #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nujabes403, thanks for the fix. I'm wondering why the API tests are failing. It shouldn't be related to the PR. I'll have a look. Update: I haven't been able to reproduce the errors locally. @holgerd77 any ideas? |
|
@s1na That's happening for some time (2-3 weeks?) now, not really sure why, seems we have to dig a bit deeper. Maybe something caching related or similar? Not sure. |
|
@nujabes403 The problem with the tests is now fixed on |
s1na
approved these changes
Jan 8, 2019
|
Thank you for review :) @s1na @holgerd77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
percomiledshould be fixed toprecompiledAfter this PR, the typo will be fixed.