Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.48.1 #5441

Closed
wants to merge 10 commits into from
Closed

Release 2.48.1 #5441

wants to merge 10 commits into from

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Oct 31, 2024

Release Checklist

The release checklist is a manual set of checks done before each release to ensure functionality of the most critical components of the application. Some of these steps are redundant with automated tests, while others are only tested here as part of this check.

This checklist should be copy/pasted into the final pre-release PR, and checked off as you complete each step.

Additionally, there is a robust Release Process page available in Confluence (internal only).

Pre-Release Steps

General

@NevilleS: For this patch release, we've skipped the general checklist steps crossed out (strikethrough) below.

From the release branch, confirm the following:

* [ ] Quickstart works: nox -s quickstart (verify you can complete the interactive prompts from the command-line)

  • Test environment works: nox -s "fides_env(test)" (verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)
    * [ ] Have Roger run a QATouch automation run

Next, run the following checks via the test environment:

API

CLI

Run these from within the test environment shell:

  • git reset --hard - Note: This is required for the pull command to work
  • fides user login
  • fides push src/fides/data/sample_project/sample_resources/
  • fides pull src/fides/data/sample_project/sample_resources/
  • fides evaluate src/fides/data/sample_project/sample_resources/
  • fides generate dataset db --credentials-id app_postgres test.yml - Note: Because the filesystem isn't mounted, the new file will only show up within the container
  • fides scan dataset db --credentials-id app_postgres

Privacy Center

  • Every navigation button works
  • DSR submission succeeds
  • Consent request submission succeeds

Admin UI

  • Every navigation button works
  • DSR approval succeeds
  • DSR execution succeeds

User Permissions

- [ ] Verify user creation
- [ ] Verify a Viewer can view all systems
~- [ ] Verify a Data Steward can edit systems they are assigned ~

Documentation

  • Verify that the CHANGELOG is formatted correctly and clean up verbiage where needed
  • Verify that the CHANGELOG is representative of the actual changes

⚠️ Note that any updates that need to be made to the CHANGELOG should not be commited directly to the release branch.
Instead, they should be committed on a branch off of main and then PR'd and merged into main, before being cherry-picked
over to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and main.

Publishing the release

When publishing the release, be sure to include the following sections in the release description:

  • ## Release Pull Request section that includes a link back to the release PR (i.e., this one!) for tracking purposes
    * [ ] ## QA Touch Test Run section that includes a link to the QATouch test run (QA team should provide this)

Post-Release Steps

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 7:54pm

Copy link

cypress bot commented Oct 31, 2024

fides    Run #10723

Run Properties:  status check passed Passed #10723  •  git commit 34e00b157d: HJ-116 - Fix BigQuery `partitioning` queries to properly support multiple identi...
Project fides
Branch Review release-2.48.1
Run status status check passed Passed #10723
Run duration 00m 38s
Commit git commit 34e00b157d: HJ-116 - Fix BigQuery `partitioning` queries to properly support multiple identi...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.86%. Comparing base (4abb9e6) to head (34e00b1).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/service/connectors/query_config.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5441      +/-   ##
==========================================
+ Coverage   83.84%   83.86%   +0.01%     
==========================================
  Files         382      382              
  Lines       24073    24073              
  Branches     2624     2624              
==========================================
+ Hits        20185    20189       +4     
+ Misses       3306     3302       -4     
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…iple identity clauses (#5432)

Co-authored-by: Neville Samuell <neville@ethyca.com>
@NevilleS NevilleS marked this pull request as ready for review October 31, 2024 21:44
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks @andres-torres-marroquin!

I'll finish the checklist and publishing the tags next.

@NevilleS NevilleS closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants