Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.51.0 #5558

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

release 2.51.0 #5558

wants to merge 6 commits into from

Conversation

Roger-Ethyca
Copy link
Contributor

@Roger-Ethyca Roger-Ethyca commented Dec 4, 2024

Release Checklist

The release checklist is a manual set of checks done before each release to ensure functionality of the most critical components of the application. Some of these steps are redundant with automated tests, while others are only tested here as part of this check.

This checklist should be copy/pasted into the final pre-release PR, and checked off as you complete each step.

Additionally, there is a robust Release Process page available in Confluence (internal only).

Pre-Release Steps

General

From the release branch, confirm the following:

  • Quickstart works: nox -s quickstart (verify you can complete the interactive prompts from the command-line)
  • Test environment works: nox -s "fides_env(test)" (verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)
  • Have Roger run a QATouch automation run

Next, run the following checks via the test environment:

API

CLI

Run these from within the test environment shell:

  • git reset --hard - Note: This is required for the pull command to work
  • fides user login
  • fides push src/fides/data/sample_project/sample_resources/
  • fides pull src/fides/data/sample_project/sample_resources/
  • fides evaluate src/fides/data/sample_project/sample_resources/
  • fides generate dataset db --credentials-id app_postgres test.yml - Note: Because the filesystem isn't mounted, the new file will only show up within the container
  • fides scan dataset db --credentials-id app_postgres

Privacy Center

  • Every navigation button works
  • DSR submission succeeds
  • Consent request submission succeeds

Admin UI

  • Every navigation button works
  • DSR approval succeeds
  • DSR execution succeeds

User Permissions

  • Verify user creation
  • Verify a Viewer can view all systems
  • Verify a Data Steward can edit systems they are assigned

Documentation

  • Verify that the CHANGELOG is formatted correctly and clean up verbiage where needed
  • Verify that the CHANGELOG is representative of the actual changes

⚠️ Note that any updates that need to be made to the CHANGELOG should not be commited directly to the release branch.
Instead, they should be committed on a branch off of main and then PR'd and merged into main, before being cherry-picked
over to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and main.

Publishing the release

When publishing the release, be sure to include the following sections in the release description:

  • ## Release Pull Request section that includes a link back to the release PR (i.e., this one!) for tracking purposes
  • ## QA Touch Test Run section that includes a link to the QATouch test run (QA team should provide this)

Post-Release Steps

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 7:05pm

Copy link

cypress bot commented Dec 4, 2024

fides    Run #11336

Run Properties:  status check passed Passed #11336  •  git commit c697a67120: Fix Fides brand link position on small screens (#5572)
Project fides
Branch Review release-2.51.0
Run status status check passed Passed #11336
Run duration 00m 38s
Commit git commit c697a67120: Fix Fides brand link position on small screens (#5572)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Co-authored-by: Adam Sachs <adam@ethyca.com>
Copy link

cypress bot commented Dec 5, 2024

fides    Run #11335

Run Properties:  status check passed Passed #11335  •  git commit 50d6fb9098 ℹ️: Merge c697a671205792d75f79d5fe7365cbfe8aa5726f into 05cf5efa6ebbf7a63586ad255036...
Project fides
Branch Review refs/pull/5558/merge
Run status status check passed Passed #11335
Run duration 00m 48s
Commit git commit 50d6fb9098 ℹ️: Merge c697a671205792d75f79d5fe7365cbfe8aa5726f into 05cf5efa6ebbf7a63586ad255036...
Committer Roger Plotz
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.03%. Comparing base (ae28e79) to head (c697a67).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/api/v1/endpoints/system.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5558      +/-   ##
==========================================
+ Coverage   78.81%   79.03%   +0.22%     
==========================================
  Files         389      389              
  Lines       24723    24727       +4     
  Branches     2702     2702              
==========================================
+ Hits        19486    19544      +58     
+ Misses       4722     4664      -58     
- Partials      515      519       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants