Record new AnalyticsEvents asynchronously
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
SteveDMurphy
previously approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Looks great @PSalant726 !! Tested everything locally and confirmed it works as expected.
Left one question about the union operator with dicts is all, great work! 🚀
The addition of the `|` operator in 267bcf5 creates a requirement for Python v3.9+.
SteveDMurphy
approved these changes
Apr 6, 2022
PSalant726
added a commit
to ethyca/fides
that referenced
this pull request
Apr 15, 2022
Fideslog v1.1.0 changes the `AnalyticsClient.send` interface such that it automatically executes the request in a separate event loop. There is no longer a need to manually wrap the call in `asyncio.run` or similar. These changes were introduced in ethyca/fideslog#50
PSalant726
added a commit
to ethyca/fides
that referenced
this pull request
Apr 18, 2022
* Update the usage of `AnalyticsClient.send`, bump fideslog to v1.1.0 Fideslog v1.1.0 changes the `AnalyticsClient.send` interface such that it automatically executes the request in a separate event loop. There is no longer a need to manually wrap the call in `asyncio.run` or similar. These changes were introduced in ethyca/fideslog#50 * Use the new `OPT_OUT_PROMPT` constant * `AnalyticsException` --> `AnalyticsError` * Bump fideslog to v1.1.1 * Bump fideslog to v1.1.2 * Bump fideslog to v1.1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
SDK Changes
event.extra_dataintoclient.extra_dataAnalyticsClient.senduses aiohttp to make asynchronous requests