Bump fideslog to v1.1.3, update usage patterns #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PSalant726 i moved this back to draft while we wait for fideslog 1.1.0 |
PSalant726
changed the title
Fideslog v1.1.0 changes the `AnalyticsClient.send` interface such that it automatically executes the request in a separate event loop. There is no longer a need to manually wrap the call in `asyncio.run` or similar. These changes were introduced in ethyca/fideslog#50
PSalant726
force-pushed
the
async-analytics
branch
from
4c79817 to
aaaf17d
Compare
PSalant726
changed the title
PSalant726
changed the title
PSalant726
changed the title
SteveDMurphy
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Nice simple implementation updates! Looks great @PSalant726 👍🏽
When first running fidesctl apply demo_resources/ after starting the container, the event was not sent - but I haven't been able to reproduce it since (removing analytics_id, restarting container, etc.). Adding as a comment in case anyone else has seen that and we want to investigate further separately
ThomasLaPiana
pushed a commit
that referenced
this pull request
Aug 17, 2022
* adds drp action type to db, adds docs, tests * fix lint, tests * format * remove unneeded func arg * lint * more lint * CR changes * update alembic down migration number * minor docs updates for drp * integration tests and updating alembic * catches integrity error at endpoint level * lint Co-authored-by: Cole Isaac <cole@ethyca.com>
ThomasLaPiana
pushed a commit
that referenced
this pull request
Sep 26, 2022
* adds drp action type to db, adds docs, tests * fix lint, tests * format * remove unneeded func arg * lint * more lint * CR changes * update alembic down migration number * minor docs updates for drp * integration tests and updating alembic * catches integrity error at endpoint level * lint Co-authored-by: Cole Isaac <cole@ethyca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ethyca/fideslog#50
Related to ethyca/fideslog#51
Code Changes
asyncio.runwhen sendingAnalyticsEventsAnalyticsException-->AnalyticsErrorOPT_OUT_COPYand retrieve input usingOPT_OUT_PROMPTSteps to Confirm
make cliPre-Merge Checklist
Description Of Changes
Fideslog v1.1.3 includes the following changes
AnalyticsClient.sendinterface automatically executes the request in a separate event loop. There is no longer a need to manually wrap the call inasyncio.runor similar.AnalyticsExceptionhas been renamed toAnalyticsError, to better align with Python conventionutils.pyfile now separately exposesOPT_OUT_COPYandOPT_OUT_PROMPT, to better enable non-CLI applications to displayOPT_OUT_COPYwithout automatically assuming a user will respond with their keyboard.