Catch AssertionErrors and raise AnalyticsErrors instead
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renames `AnalyticsException` --> `AnalyticsError`, to align with Python convention. All error types inherit from `AnalyticsError` to enable consumers of this library to simply catch `AnalyticsError`s in their code.
PSalant726
added a commit
that referenced
this pull request
Apr 7, 2022
PSalant726
added a commit
that referenced
this pull request
Apr 7, 2022
SteveDMurphy
previously approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Looks great @PSalant726 !! Great changes all around and sorry for the holdup here.
Added a question around validating empty strings from events, but on further thought I am not so sure it should be something that kicks back an error 🤷🏽
SteveDMurphy
approved these changes
Apr 9, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
SDK Changes
AnalyticsException-->AnalyticsErrorAnalyticsErrorAssertionErrorwhen instantiating invalidAnalyticsClients and/orAnalyticsEvents, and raise usefulAnalyticsErrors instead