CMake Spring Cleaning #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been replaced with a upgraded file.
Header changes, and download shields link to releases page.
Updated image and explanation for macOS Gatekeeper.
Typo fixes were suggested on discord from donte (Providence), Fission, and poco.
The old file is now completely irrelevant, and has been removed, with the new one taking it's place.
Somehow these tags made it through all previous testing. They have now been switched for native compiler comparability.
|
Priority changed to medium. It contains a build fix on windows that could cause both 32bit and 64bit ffmpeg to always be linked, even if the current build architecture does not call for one or the other to be linked. |
Details are to tell potential contributions how they could work on something new.
…FORM CMAKE_GENERATOR while was usable, is not compatible across different Windows generators. CMAKE_GENERATOR_PLATFORM adds usability across all recent CMake generators, and standardizes how the CMake command is used across visual studio generators.
Since some libraries are statically linked, we had to add the logic to tell what to statically link if we're using ninja. Anything built from source does not require this logic. Maybe this can be revisited in the future to simplify it, since it is significant duplicate code, though I believe this is preferable to having a custom `USING_NINJA` variable in the CMake script.
Previously, all warnings produced by any library would be displayed in the console. Now, it has been significantly suppressed by removing the CMake default warning level, and overriding the variable at the directory level in extern/CMakeLists.txt
All information within the Building-Docs.md file has been updated and rewritten in the Building.md file
This directory provided a significant amount of bloat to the repository, and has been removed, since these files are no longer apart of the build toolchain.
This file is not apart of the build toolchain.
poco0317
requested changes
May 12, 2019
poco0317
approved these changes
May 12, 2019
This commit changes from self-defined to compiler defined preprocessor directives. CPU_X86 -> __i386__ CPU_X86_64 -> __x86_64__ This change cuts down on PPD's we worry about and leave it to the compiler (which any modern compiler will have them defined).
The commit fixes a critical bug where all audio files would not be properly read, and therefore cause the game on startup when reading from the Songs directory. The config.mad.in.h was restored, and added into the CMakeLists.txt file to be generated into a config.h in the libmad build directory.
nico-abram
approved these changes
May 16, 2019
The macOS linker "ld" does not seem to have the option "--no-as-needed", so lwyu is disabled on macOS.
This was referenced May 17, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my eighth PR on this repository.
Here is a summary of everything to be changed in this pull request.
Required before merge
clang-format(To be completed in isolated PR due to complexity of solving the issues this project has with consistent formatting, and not wanting to do aFormatting changescommit with a large diff)include_what_you_use(Also to be completed in isolated PR as it requires significant changes)Other Fixes
RageSoundReader_FileReaderobject atSong.cpp:706)15b505d