Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MinaCalc linking logic #529

Merged
merged 1 commit into from
May 17, 2019

Conversation

jameskr97
Copy link
Member

MinaCalc_x86.lib would still attempt to link on macOS, even though it is a windows only lib. The compiler notices this, and choses not to link it, thought removing the possibility of it happening is better than letting the compiler deal with it.

Intended to be apart of #514.

MinaCalc_x86.lib would still attempt to link on macOS, even though it is a windows only lib. The compiler notices this, and choses not to link it, thought removing the possibility of it happening is better than letting the compiler deal with it.
@jameskr97 jameskr97 self-assigned this May 17, 2019
@nico-abram
Copy link
Member

👍

@nico-abram nico-abram merged commit 4458984 into etternagame:develop May 17, 2019
@jameskr97 jameskr97 deleted the cmake-spring-cleaning branch May 22, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants