This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 569
fix: eip712 support for pubkey any messages #1076
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR would close |
@zmanian we also would need to remove the single signature check as @tony-iqlusion mentioned |
Iqlusion would be willing to join the validator set with a single sig ledger backed key. |
It's a partial fix for the issue. |
Codecov Report
@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
+ Coverage 59.39% 59.49% +0.09%
==========================================
Files 85 84 -1
Lines 6992 6940 -52
==========================================
- Hits 4153 4129 -24
+ Misses 2622 2598 -24
+ Partials 217 213 -4
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
fedekunze
added
pinned
Pinned issues that won't be closed by stalebot
and removed
Status: Stale
labels
Jul 11, 2022
Replaced by this #1283 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Most messages with EIP712 are working fine, but the code is not working if some values that are not the cosmos transaction itself, are contained inside a
proto.Any
object.The issue is that when we create read the transactions values, they are parsed using the JSON lib, for example, for public keys it returns the base64 representation of the pubkey as a
string
.When the lib generates the types for the EIP712 message, it uses codec.UnpackAny if the message is contained inside a
proto.Any
object it will return {type:string, value:...} instead of the expectedstring
For now the only value that I found that is sent as a
proto.Any
message is the pubkey, but I need to review the rest of the cosmos-sdk messagesFor contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)