Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Improve eip712 compatibility #1283

Closed
wants to merge 7 commits into from
Closed

Improve eip712 compatibility #1283

wants to merge 7 commits into from

Conversation

ramacarlucho
Copy link
Contributor

Closes: #1245 #1247

Description

The current implementation for eip712 only supports amino encoded msgs. This changes aim to detect the current encoding of the msg and the inner structures and create the eip712 types accordingly.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@facs95 facs95 linked an issue Aug 19, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Canceled
Development

Successfully merging this pull request may close these issues.

EIP712 doesn't support optional parameters Eip712 doesn't support any messages
3 participants