Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Add support for miner_setGasPrice API #1237

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Add support for miner_setGasPrice API #1237

merged 1 commit into from
Aug 12, 2022

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Aug 12, 2022

Closes: #XXX

Description

This PR fixes a regression from the RPC refractor.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1237 (6b84ebb) into main (77ed4aa) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   52.29%   52.16%   -0.13%     
==========================================
  Files         105      105              
  Lines        9519     9542      +23     
==========================================
  Hits         4978     4978              
- Misses       4274     4297      +23     
  Partials      267      267              
Impacted Files Coverage Δ
rpc/backend/backend.go 51.72% <ø> (ø)
rpc/backend/node_info.go 0.00% <0.00%> (ø)

@fedekunze fedekunze merged commit 9891920 into main Aug 12, 2022
@fedekunze fedekunze deleted the set-gas-price branch August 12, 2022 06:23
facs95 added a commit that referenced this pull request Aug 12, 2022
@facs95 facs95 mentioned this pull request Aug 12, 2022
11 tasks
fedekunze added a commit that referenced this pull request Aug 13, 2022
* changelog

* Add support for miner_setGasPrice API (#1237)

* fix kv indexer unit test

* fix(rpc): get_proof test fail because block numbers are not high enough (#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* tests(rpc): add filter tests (#1233)

* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* changelog

* update gomod2nix

* fix python linter

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Aug 17, 2022
* changelog

* Add support for miner_setGasPrice API (evmos#1237)

* fix kv indexer unit test

* fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* tests(rpc): add filter tests (evmos#1233)

* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* changelog

* update gomod2nix

* fix python linter

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
* changelog

* Add support for miner_setGasPrice API (evmos#1237)

* fix kv indexer unit test

* fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* tests(rpc): add filter tests (evmos#1233)

* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* changelog

* update gomod2nix

* fix python linter

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 3762738)
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants