Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(rpc): get_proof test fail because block numbers are not high enough #1239

Merged
merged 5 commits into from
Aug 12, 2022
Merged

fix(rpc): get_proof test fail because block numbers are not high enough #1239

merged 5 commits into from
Aug 12, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Aug 12, 2022

Description

Solution:

  • wait for app block height rather than tendermint block height

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang
Problem: get_proof test fail because block numbers are not high enough
c28e2ee 
Solution:
- wait for app block height rather than tendermint block height
@yihuang yihuang mentioned this pull request Aug 12, 2022
Merged
danburck
danburck approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihuang LGTM, lets merge this. And I'll update my PR: #1233

@danburck
Copy link
Contributor

@yihuang Integration tests are still failing

@yihuang
Copy link
Contributor Author

yihuang commented Aug 12, 2022

@yihuang Integration tests are still failing

fixed, this time it's a real bug.

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1239 (cc65a17) into main (9891920) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1239   +/-   ##
=======================================
  Coverage   52.16%   52.17%           
=======================================
  Files         105      105           
  Lines        9542     9541    -1     
=======================================
  Hits         4978     4978           
+ Misses       4297     4296    -1     
  Partials      267      267
Impacted Files Coverage Δ
rpc/backend/account_info.go 0.00% <0.00%> (ø)

@fedekunze fedekunze changed the title Problem: get_proof test fail because block numbers are not high enough fix(rpc): get_proof test fail because block numbers are not high enough Aug 12, 2022
@fedekunze fedekunze merged commit 94cab52 into evmos:main Aug 12, 2022
@yihuang yihuang deleted the fix-proof-test branch August 12, 2022 11:21
facs95 pushed a commit that referenced this pull request Aug 12, 2022
@yihuang @danburck @facs95
fix(rpc): get_proof test fail because block numbers are not high enou…
5fd2b2f 
…gh (#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
@facs95 facs95 mentioned this pull request Aug 12, 2022
Merged
11 tasks
fedekunze added a commit that referenced this pull request Aug 13, 2022
@facs95 @yihuang
@danburck @fedekunze
Cherry pick latest changes (#1265)
3762738 
* changelog

* Add support for miner_setGasPrice API (#1237)

* fix kv indexer unit test

* fix(rpc): get_proof test fail because block numbers are not high enough (#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* tests(rpc): add filter tests (#1233)

* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* changelog

* update gomod2nix

* fix python linter

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Aug 17, 2022
@facs95 @yihuang
@danburck @fedekunze
Cherry pick latest changes (evmos#1265)
b7acaa6 
* changelog

* Add support for miner_setGasPrice API (evmos#1237)

* fix kv indexer unit test

* fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* tests(rpc): add filter tests (evmos#1233)

* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* changelog

* update gomod2nix

* fix python linter

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
@facs95 @devon-chain
Cherry pick latest changes (evmos#1265)
d3e5f16 
* changelog

* Add support for miner_setGasPrice API (evmos#1237)

* fix kv indexer unit test

* fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* tests(rpc): add filter tests (evmos#1233)

* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* changelog

* update gomod2nix

* fix python linter

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 3762738)
@danburck danburck mentioned this pull request Nov 30, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danburck danburck danburck approved these changes

@fedekunze fedekunze fedekunze approved these changes

@ramacarlucho ramacarlucho ramacarlucho approved these changes

@facs95 facs95 Awaiting requested review from facs95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yihuang @danburck @ramacarlucho @fedekunze