-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esl-media-query): ingore tuple values if query syntax passed #2452
Conversation
The only open questions (for voting I guess) is the new method name and signature. For the context: The purpose of creating this method appeared
Three is an existing method
We have a "low level" Please make me know if there is a concern with that point FYI: @exadel-inc/esl-all-contributors |
7a6eef9
to
438c1a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13962 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 438c1a9 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 61.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 64.7% (-0.5% change). View more on Code Climate. |
b8635fa
to
1899484
Compare
…list-parse` rule for current snapshot state
93b4bed
to
025166e
Compare
🎉 This issue has been resolved in version 5.0.0-beta.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes: #2377