-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esl-carousel + esl-event-listener): Bunch of updates for carousel API, wheel plugin and core wheel target #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o carousel change event
…ome wheel events by predicate
…CarouselWheelMixin
… trough ESLWheelTarget
…le to prevent default wheel action
cfd930c
to
d3ad98a
Compare
abarmina
approved these changes
Jul 1, 2024
NastaLeo
reviewed
Jul 1, 2024
NastaLeo
approved these changes
Jul 1, 2024
dshovchko
approved these changes
Jul 1, 2024
fshovchko
approved these changes
Jul 1, 2024
Co-authored-by: Anastasiya Lesun <72765981+NastaLeo@users.noreply.github.com>
25c3182
to
acbfff2
Compare
yadamskaya
approved these changes
Jul 1, 2024
🎉 This PR is included in version 5.0.0-beta.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: API updates (single option param) for Carousel PLuging will be rediscussed on weekly and implemented separately