Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esl-mixin-element): major fix for nested hierarchy mixin disconnection #2506

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Jul 11, 2024

Closes: #2505

@ala-n ala-n added the needs review The PR is waiting for review label Jul 11, 2024
@ala-n ala-n added this to the ⚡ESL: 4.17.* Minor updates milestone Jul 11, 2024
@ala-n ala-n requested review from a team July 11, 2024 12:29
@ala-n ala-n self-assigned this Jul 11, 2024
@ala-n ala-n requested review from dshovchko, fshovchko and NastaLeo and removed request for a team July 11, 2024 12:29
Co-authored-by: Anna <abarmina@exadel.com>
Copy link

codeclimate bot commented Jul 11, 2024

Code Climate has analyzed commit 3deab66 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 65.3% (0.0% change).

View more on Code Climate.

@ala-n ala-n merged commit 5d74d0f into main Jul 11, 2024
8 checks passed
@ala-n ala-n deleted the hotfix/mixin-livecycle-disconnect branch July 11, 2024 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
@ala-n
Copy link
Collaborator Author

ala-n commented Jul 12, 2024

🎉 This issue has been resolved in version 4.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Jul 12, 2024
@ala-n
Copy link
Collaborator Author

ala-n commented Jul 15, 2024

🎉 This issue has been resolved in version 5.0.0-beta.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛❗in esl-mixin-element]: ESLMixinElment instances does not disconnected deep in tree hierarchy
5 participants