Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛❗in esl-mixin-element]: ESLMixinElment instances does not disconnected deep in tree hierarchy #2505

Closed
ala-n opened this issue Jul 11, 2024 · 2 comments · Fixed by #2506
Assignees
Labels

Comments

@ala-n
Copy link
Collaborator

ala-n commented Jul 11, 2024

Steps To Reproduce

  1. Create nested DOM hierarchy with mixins
   <div>
       <div my-mixin></div>
       <div my-mixin>
            <div my-mixin></div>
       </div>
   </div>
   class MyMixin extends ESLMixinElement {
      static is = 'my-mixin';
      disconnectedCallback() {
         console.log('%o disconnected', this);
         super.disconnectedCallback();
      }
   }
  1. Make sure the hierarchy was added to the active DOM
  2. Remove the hierarchy root from the active DOM tree
  3. Check if disconnected callbacks were called for mixins

Current behavior
Nested mixin instances are not disconnected

Expected behavior
Mixin should be disconnected independently of the root cause if it is not longer in the active DOM tree.

@ala-n ala-n added waits triage Issue that waits to be reviewed and handled bug Something isn't working hotfix and removed waits triage Issue that waits to be reviewed and handled labels Jul 11, 2024
@ala-n ala-n self-assigned this Jul 11, 2024
@ala-n ala-n added this to the ⚡ESL: 4.17.* Minor updates milestone Jul 11, 2024
@ala-n ala-n closed this as completed in d360da0 Jul 11, 2024
ala-n pushed a commit that referenced this issue Jul 12, 2024
# [4.18.0](v4.17.1...v4.18.0) (2024-07-12)

### Bug Fixes

* **deps:** bump puppeteer from 22.11.1 to 22.11.2 ([8a824cf](8a824cf))
* **deps:** bump puppeteer from 22.11.2 to 22.12.0 ([2a5c371](2a5c371))
* **deps:** bump puppeteer from 22.12.0 to 22.12.1 ([56ebbfa](56ebbfa))
* **deps:** bump webpack from 5.92.0 to 5.92.1 ([6909d17](6909d17))
* **deps:** bump ws from 7.5.9 to 7.5.10 ([330fd97](330fd97))
* **esl-mixin-element:** major fix for nested hierarchy mixin disconnection ([d360da0](d360da0)), closes [#2505](#2505)

### Features

* **lint:** deprecation rule for `ESlMediaRuleList.parse` ([#2509](#2509)) ([a1f916a](a1f916a))
@ala-n
Copy link
Collaborator Author

ala-n commented Jul 12, 2024

🎉 This issue has been resolved in version 4.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Jul 12, 2024
ala-n pushed a commit that referenced this issue Jul 15, 2024
## [5.0.0-beta.24](v5.0.0-beta.23...v5.0.0-beta.24) (2024-07-15)

### Features

* **lint:** deprecation rule for `ESlMediaRuleList.parse` ([#2509](#2509)) ([a1f916a](a1f916a))

### Bug Fixes

* **esl-carousel:** fix handling of pointercancel event by touch plugin ([fb91710](fb91710))
* **esl-carousel:** make animated carousel area equal to the content without padding ([1c1f6d8](1c1f6d8))
* **esl-event-listener:** fix missing signature for `$$on` method of base component ([7197e30](7197e30))
* **esl-mixin-element:** major fix for nested hierarchy mixin disconnection ([d360da0](d360da0)), closes [#2505](#2505)
@ala-n
Copy link
Collaborator Author

ala-n commented Jul 15, 2024

🎉 This issue has been resolved in version 5.0.0-beta.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant